Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up useDocument hook #401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clean up useDocument hook #401

wants to merge 1 commit into from

Conversation

msakrejda
Copy link
Contributor

  • drop unnecessary useRef
  • drop unnecessary check for id (a null id cannot yield a non-null handle)
  • drop unnecessary function wrapping a rerender callback

@msakrejda
Clean up useDocument hook
d213284 
 - drop unnecessary useRef
 - drop unnecessary check for id (a null id cannot yield a non-null handle)
 - drop unnecessary function wrapping a rerender callback
@msakrejda msakrejda force-pushed the remove-stray-ref-in-useDocument branch from 7bcf4dd to d213284 Compare December 8, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msakrejda