Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync bug test #374

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Sync bug test #374

merged 2 commits into from
Aug 13, 2024

Conversation

pvh
Copy link
Member

@pvh pvh commented Aug 13, 2024

Here's a test that I think exercises the bug you describe (as well as a PNPM update)... but it's passing!

I wonder if it's because IndexedDB is slower, somehow? Did I not understand the description of the bug you reported?

@pvh pvh merged commit f4f240b into main Aug 13, 2024
0 of 2 checks passed
@pvh
Copy link
Member Author

pvh commented Aug 13, 2024

Okay... right, so looking at this more closely I realize that when I see if the data is being synced to charlie... it causes it to be synced to charlie, which is why this test was passing. I just pushed a fix to main which exposes the synchronizer for testing / debugging purposes but flags them as hidden since I'm not promising to maintain that API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant