remove the awaiting_network states from dochandle #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, since it is always run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the AWAITING_NETWORK and NETWORK_READY states from DocHandle -- instead, the Repo just waits until the networksubsystem is in a sync-able state before triggering synchronization.
Note that this patch caused me to notice (but not yet fix) a subtle problem: if you have no local data AND you try but do not succeed in connecting to the network, you will never enter "unavailable" and your handle will lurk in "loading" forever more.
I suspect we can untangle that particular problem as we go on the cleanup but I wanted to note it.