New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document id / url type guards can accept unknown #362

Closed

marionauta wants to merge 1 commit into automerge:main from marionauta:feat/document-type-guards

Contributor

marionauta commented Jul 23, 2024

Type guards usually accept unknown value type to be as generic as possible.
It allows more values to be checked, like undefined. The isValidAutomergeUrl was already accepting null and undefined values. This PR extends that.
This shouldn't break existing code since users are already using the guards with strings.

isValidDocumentId(undefined) // false
isValidDocumentId(1) // false


          document id/url type guards can accept unknown

ef45b55

Member

pvh commented Jul 24, 2024

Good point! I added a test for a previously unrequestable value and merged it. Thanks.

pvh closed this

marionauta deleted the feat/document-type-guards branch

July 25, 2024 08:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet