Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0 release chore] remove useBootstrap #331

Closed
wants to merge 1 commit into from
Closed

Conversation

pvh
Copy link
Member

@pvh pvh commented Apr 4, 2024

useBootstrap was a good idea (maybe), poorly executed (by me).

Instead of this confusing and complicated bit of obfuscation that's really only fit for demo code, we now use a much shorter and more transparent stanza in examples:

const rootDocUrl = `${document.location.hash.substring(1)}`
let handle
if (isValidAutomergeUrl(rootDocUrl)) {
  handle = repo.find(rootDocUrl)
} else {
  handle = repo.create<State>({ todos: [] })
}
const docUrl = (document.location.hash = handle.url)

Out of respect for semver, I've marked it as deprecated for now and made this PR to remember to finish it off later.

@pvh pvh self-assigned this Apr 4, 2024
@pvh pvh marked this pull request as draft April 4, 2024 20:17
@pvh pvh changed the title remove useBootstrap (merge for 2.0) [2.0 release chore] remove useBootstrap Apr 4, 2024
@pvh
Copy link
Member Author

pvh commented Jul 24, 2024

@alexjg since we're changing the NetworkAdapter API and doing a major we should merge this

@pvh pvh force-pushed the main branch 2 times, most recently from e61f8e3 to d3d1a7d Compare July 26, 2024 20:13
@pvh
Copy link
Member Author

pvh commented Aug 15, 2024

Merged as part of 2.0

@pvh pvh closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant