-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing initial value for when creating documents #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initialValue can only be set when isNew=true, and timeoutDelay is mutually exclusive from either
pvh
force-pushed
the
repo-initial-value
branch
from
January 23, 2024 22:52
91b8f3f
to
f536d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Creating a document in a repo is currently a two-step process: First you create the handle -- at which point the type of your
document is a filthy lie, because its value is
{}
regardless of what you may have asserted. Then you have to useDocHandle.change()
to set the various properties of your desired initial state:A better world is possible! One where this is done in a single step, and you don't have to endure that terrifying millisecond
without type safety.
How
When creating a new
DocHandle
withisNew
, you can pass an initial value for the document:Similarly, when creating a new document with
Repo.create()
, you can pass an initial value: