Remove onInvalidAutomergeUrl from useBootstrap #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to be able to do something like |
|
I think this is a great idea but is technically a breaking change to the API. I've been hesitant to merge it because of that even though I suspect nobody will be using it. |
|
Also, it's worth noting that passing in a bad AutomergeUrl should emit an error from the DocHandle so this is probably totally redundant anyway. |
|
Moot with usebootstrap gone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
onInvalidAutomergeUrlfrom useBootstrap.The alternative is to use a react error boundary. From my understanding, this wasn't possible at the time.