Get eslint working with GitHub actions #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HerbCaudill
commented
Dec 28, 2023
HerbCaudill
commented
- Makes eslint happy either by fixing code or disabling rules (locally or globally)
- Uses a single config file and lint command at the monorepo root
- Updates the lint workflow to work with pnpm rather than yarn
pvh
reviewed
Dec 29, 2023
pvh
reviewed
Dec 29, 2023
| @@ -330,10 +334,10 @@ export class DocSynchronizer extends Synchronizer { | |||
| } | |||
|
|
|||
| this.#processAllPendingSyncMessages() | |||
| this.#processSyncMessage(message, new Date()) | |||
pvh
reviewed
Dec 29, 2023
There was a problem hiding this comment.
Couple of little things -- one is just a typo and the other I'm less clear on. Why did you remove the date argument from the processSyncMessage? Was it unused? Let's ping @alexjg or @paulsonnentag to see if they know what's up there.
|
Yeah, eslint flagged the date parameter as unused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.