Switch to pnpm #249
Merged
Switch to pnpm #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerbCaudill
commented
Dec 4, 2023
| @@ -1,5 +1,5 @@ | |||
| import { next as A } from "@automerge/automerge" | |||
| import { MessageChannelNetworkAdapter } from "@automerge/automerge-repo-network-messagechannel" | |||
| import { MessageChannelNetworkAdapter } from "../../automerge-repo-network-messagechannel/src/index.js" | |||
There was a problem hiding this comment.
Doing it this way because otherwise pnpm reports a circular dependency (which it technically is, but this is a test so it doesn't really matter).
HerbCaudill
commented
Dec 4, 2023
| "dev": "run-p watch start:syncserver dev:demo", | ||
| "pub": "lerna publish --yes", | ||
| "start:syncserver": "cross-env DEBUG='WebsocketServer' yarn workspace @automerge/example-sync-server start", | ||
| "start:syncserver": "cross-env DEBUG='WebsocketServer' pnpm -F @automerge/example-sync-server start", | ||
| "preinstall": "npx only-allow pnpm", |
There was a problem hiding this comment.
this helps us avoid accidentally running yarn install etc
HerbCaudill
commented
Dec 4, 2023
Comment on lines
+16
to
+18
| "@automerge/automerge-repo": "workspace:*", | ||
| "debug": "^4.3.4", | ||
| "eventemitter3": "^5.0.1" |
There was a problem hiding this comment.
pnpm is stricter about packages only using dependencies that they declare, whereas yarn let us get away with being sloppy.
This was referenced Dec 5, 2023
Merged
Merged
Closed
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
This LVGTM. @pvh any concerns? |
pvh
reviewed
Dec 6, 2023
pvh
reviewed
Dec 6, 2023
HerbCaudill
force-pushed
the
refactor-websocket-adapters
branch
from
af5dd03 to
50db010
Compare
HerbCaudill
force-pushed
the
refactor-websocket-adapters
branch
from
50db010 to
3eeef12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces yarn 1.x with pnpm as package manager for the repo.