NodeFSStorageAdapter: refactor #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Oct 31, 2023
pvh
reviewed
Oct 31, 2023
| }) | ||
| ) | ||
|
|
||
| return result | ||
| } | ||
|
|
||
| async removeRange(keyPrefix: string[]): Promise<void> { |
There was a problem hiding this comment.
we should refuse to run this without a key value; pretty sure someone accidentally passing in undefined / empty array would delete everything they have
There was a problem hiding this comment.
ok - that should be a separate PR
|
Okay! Some description would be nice for this one. |
HerbCaudill
commented
Nov 1, 2023
| export class NodeFSStorageAdapter extends StorageAdapter { | ||
| private baseDirectory: string | ||
| private cache: { | ||
| [key: string]: { storageKey: StorageKey; data: Uint8Array } |
There was a problem hiding this comment.
no reason to store the storageKey in the cache as both a value and a key.
HerbCaudill
commented
Nov 1, 2023
| } else { | ||
| throw error | ||
| } | ||
| } |
There was a problem hiding this comment.
This logic has been moved to walkdir
|
|
||
| // The "keys" in the cache don't include the baseDirectory. | ||
| // We want to de-dupe with the cached keys so we'll use getKey to normalize them. | ||
| const diskKeys: string[] = diskFiles | ||
| .flat(Infinity) // the walk function returns a nested array |
There was a problem hiding this comment.
walkdir returns a flattened array
| await rimraf(dirPath) | ||
| } | ||
|
|
||
| private getKey(key: StorageKey): string { | ||
| return path.join(...key) |
There was a problem hiding this comment.
getKey and cacheKey do the same thing
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes in behavior, just some minor refactoring for clarity.