Support AUTHGEAR_WEB_SDK_SESSION_TYPE #42
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tung2744
reviewed
Jan 14, 2025
Comment on lines
+353
to
+363
| {{- if (eq .Values.authgear.portalServer.authgear.webSDKSessionType "cookie") }} | ||
| - port: 80 | ||
| targetPort: proxy | ||
| protocol: TCP | ||
| name: http | ||
| {{- else }} | ||
| - port: 80 | ||
| targetPort: portal | ||
| protocol: TCP | ||
| name: http | ||
| {{- end }} |
There was a problem hiding this comment.
I think access token should work with the proxy too so maybe we can simply always use the proxy?
There was a problem hiding this comment.
I will not include a separate proxy for the portal in ONCE, so it is better align the deployment. When sessionType=refresh_token, there is no dedicated proxy in front of the portal.
There was a problem hiding this comment.
staging has been updated to use this change now. Encountered an issue https://linear.app/authgear/issue/DEV-2432/validatescopes-does-not-respect-always-allowed-grant-types but that can be worked around by setting grant_types explicitly.
There was a problem hiding this comment.
This should be good to merge.
louischan-oursky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-2326