Allow example app to be built in arm64 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louischan-oursky
requested changes
Oct 28, 2024
| @@ -6,7 +6,7 @@ target 'ios_example' do | |||
| use_frameworks! | |||
|
|
|||
| # Pods for ios_example | |||
| pod 'WechatOpenSDK', '~> 2.0.4' | |||
| pod 'WechatOpenSDK-XCFramework', '~> 2.0.4' | |||
There was a problem hiding this comment.
Please include this link as comment above this line. https://developers.weixin.qq.com/community/develop/doc/000c62b9b0ccf8c1d65fa90b751001?blockType=1
From the link, it says that we need to change the header include macro from "" to <>. I wonder why we did not do so.
For the removal of the .a and .h files, I guess Cocoapods has handled that for us. So no action is required from us.
There was a problem hiding this comment.
From the link, it says that we need to change the header include macro from "" to <>. I wonder why we did not do so.
It is because I found that "" seems also working. Let me change it back to <> according to the doc.
louischan-oursky
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-2121