Update SDK reference for authenticate param #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louischan-oursky
requested changes
Sep 5, 2024
| @@ -818,10 +818,8 @@ public class Authgear { | |||
| /// - xState: Use this parameter to provide parameters from the client application to Custom UI. The string in xState can be accessed by the Custom UI. Ignore this parameter if default AuthUI is used | |||
| public func authenticate( | |||
| redirectURI: String, | |||
| state: String? = nil, | |||
There was a problem hiding this comment.
Apply the same change to reauthenticate() promoteAnonymousUser()
There was a problem hiding this comment.
removed state from reauthenticate() promoteAnonymousUser() and added xState description to them as well
|
@mickmak-busicat You need to format the code. The build failed. |
mickmak-busicat
force-pushed
the
fix/dev-1693-update-sdk-reference-for-not-used-param
branch
from
357c0f5 to
bbc2c3e
Compare
|
sorry missed that🙏 fixed up |
louischan-oursky
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@louischan-oursky see if this approach ok or not
i found there is already a
private authenticatefunction for handling a completeAuthenticateOptionparam, and all places usingpublic authenticatefunction didnt use the two params that need to be hidden. so if they are not exposing then should be ok to remove from thepublic authenticatefunctionPreview: