Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-863: Fix how we fetch organizations by name in data source #877

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

This PR fixes the logic on fetching organizations by name by leveraging the dedicated endpoint https://auth0.com/docs/api/management/v2/organizations/get-name-by-name instead of using offset pagination and looping through the results. This fixes #863

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner November 9, 2023 12:33
@codecov-commenter
Copy link

Codecov Report

Merging #877 (8771b4f) into main (0a39d61) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files         101      101           
  Lines       13799    13782   -17     
=======================================
- Hits        12415    12401   -14     
+ Misses        983      980    -3     
  Partials      401      401           
Files Coverage Δ
internal/auth0/organization/data_source.go 87.03% <100.00%> (+5.43%) ⬆️

... and 1 file with indirect coverage changes

@sergiught sergiught merged commit 0ebbe3f into main Nov 9, 2023
4 checks passed
@sergiught sergiught deleted the GH-863-orgs-data-source-fetch-all branch November 9, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan and apply failing due to records limit
4 participants