Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth0_client Testcases #1125

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Fix auth0_client Testcases #1125

merged 3 commits into from
Jan 16, 2025

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Jan 16, 2025

Fix broken test recordings

🔧 Changes

Re-recorded TestAccDataClients and TestAccClientOIDCLogout test case allowing the workflow to pass.
In auth0_client, set oidc_logout as computed to avoid noisy plan.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@acwest acwest requested a review from a team as a code owner January 16, 2025 21:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (469673d) to head (8b25a47).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         130      130           
  Lines       18057    18060    +3     
=======================================
+ Hits        16109    16112    +3     
  Misses       1379     1379           
  Partials      569      569           
Files with missing lines Coverage Δ
internal/auth0/client/resource.go 98.50% <100.00%> (+<0.01%) ⬆️

@acwest acwest merged commit ed23c52 into main Jan 16, 2025
5 checks passed
@acwest acwest deleted the dummy branch January 16, 2025 22:21
@ramya18101 ramya18101 changed the title Test Fix auth0_client Testcases Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants