Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for failing "integration test (CRA)" #769

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Workaround for failing "integration test (CRA)" #769

merged 4 commits into from
Jun 21, 2024

Conversation

nandan-bhat
Copy link
Contributor

@nandan-bhat nandan-bhat commented Jun 19, 2024 •
edited
Loading

Description

Currently we are unable to merge any PR to the main because integration test (CRA) and integration test (Gatsby) are failing when the Github runs checks. This issue is caused by one of the sub-dependancy (ajv) update in the example app examples/cra-react-router. The changes made in the pull-request serve as a temporary workaround rather than a definitive solution.

References

Original issue; failing Integration Tests / Run example tests (pull_request_target).

image

Testing

With this PR changes, all the integration tests and workflow checks should get passed.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@nandan-bhat nandan-bhat requested a review from a team as a code owner June 19, 2024 10:55
gyaneshgouraw-okta
gyaneshgouraw-okta approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@gyaneshgouraw-okta gyaneshgouraw-okta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also check an approach where we add package.lock and update the version of ajv in lockfile. That may help us avoid adding a new dependency.

@nandan-bhat nandan-bhat merged commit 4ec5410 into main Jun 21, 2024
14 checks passed
@nandan-bhat nandan-bhat deleted the bugfix/SDK-4872 branch June 21, 2024 13:12
@tusharpandey13 tusharpandey13 mentioned this pull request Jan 21, 2025
Merged
tusharpandey13 added a commit that referenced this pull request Jan 21, 2025
@tusharpandey13
Release v2.3.0 (#825)
88f9ddb 
**Added**
- Feature/react19 [\#824](#824)
([tusharpandey13](https://github.com/tusharpandey13))
- Add ReversingLabs Workflow (Don't Merge)
[\#782](#782)
([developerkunal](https://github.com/developerkunal))

**Changed**
- Bump next from 13.5.6 to 14.1.1 in /examples/nextjs-app
[\#761](#761)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @testing-library/react from 14.1.2 to 14.3.1
[\#757](#757)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ts-jest from 29.1.1 to 29.1.5
[\#766](#766)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump cypress from 13.6.1 to 13.12.0
[\#770](#770)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump braces from 3.0.2 to 3.0.3
[\#773](#773)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/jest from 29.5.11 to 29.5.12
[\#750](#750)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/react from 18.2.45 to 18.2.64
[\#747](#747)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump browserstack-cypress-cli from 1.28.0 to 1.28.1
[\#715](#715)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump typedoc from 0.25.4 to 0.25.7
[\#713](#713)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- ci: changed pull_request_target to pull_request and removed the
authorize step [\#796](#796)
([desusai7](https://github.com/desusai7))
- Update codeowner file with new GitHub team name
[\#790](#790)
([stevenwong-okta](https://github.com/stevenwong-okta))
- Bump jose from 4.11.0 to 4.15.5 in /examples/users-api
[\#749](#749)
([dependabot[bot]](https://github.com/apps/dependabot))
- Workaround for failing "integration test (CRA)"
[\#769](#769)
([nandan-bhat](https://github.com/nandan-bhat))

**Security**
- Bump pretty-quick from 3.1.3 to 3.3.1
[\#736](#736)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump express from 4.18.2 to 4.19.2 in /examples/users-api
[\#754](#754)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump follow-redirects from 1.15.3 to 1.15.6
[\#752](#752)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ws from 7.5.9 to 7.5.10
[\#768](#768)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump oidc-provider from 8.4.3 to 8.4.5
[\#720](#720)
([dependabot[bot]](https://github.com/apps/dependabot))
@tusharpandey13 tusharpandey13 mentioned this pull request Jan 21, 2025
Merged
tusharpandey13 added a commit that referenced this pull request Jan 21, 2025
@tusharpandey13
Release v2.3.0 (#828)
1644bb5 
**Added**
- Release v2.3.0 [\#825](#825)
([tusharpandey13](https://github.com/tusharpandey13))
- Feature/react19 [\#824](#824)
([tusharpandey13](https://github.com/tusharpandey13))
- Add ReversingLabs Workflow (Don't Merge)
[\#782](#782)
([developerkunal](https://github.com/developerkunal))

**Changed**
- ci: changed pull_request_target to pull_request and removed the
authorize step [\#796](#796)
([desusai7](https://github.com/desusai7))
- Bump @testing-library/react from 14.1.2 to 14.3.1
[\#757](#757)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ts-jest from 29.1.1 to 29.1.5
[\#766](#766)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump cypress from 13.6.1 to 13.12.0
[\#770](#770)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/jest from 29.5.11 to 29.5.12
[\#750](#750)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/react from 18.2.45 to 18.2.64
[\#747](#747)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump browserstack-cypress-cli from 1.28.0 to 1.28.1
[\#715](#715)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- fix npm release workflow
[\#826](#826)
([tusharpandey13](https://github.com/tusharpandey13))
- Update codeowner file with new GitHub team name
[\#790](#790)
([stevenwong-okta](https://github.com/stevenwong-okta))
- Workaround for failing "integration test (CRA)"
[\#769](#769)
([nandan-bhat](https://github.com/nandan-bhat))

**Removed**
- Revert "Release v2.3.0"
[\#827](#827)
([tusharpandey13](https://github.com/tusharpandey13))

**Security**
- Bump pretty-quick from 3.1.3 to 3.3.1
[\#736](#736)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump next from 13.5.6 to 14.1.1 in /examples/nextjs-app
[\#761](#761)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump jose from 4.11.0 to 4.15.5 in /examples/users-api
[\#749](#749)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump express from 4.18.2 to 4.19.2 in /examples/users-api
[\#754](#754)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump follow-redirects from 1.15.3 to 1.15.6
[\#752](#752)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ws from 7.5.9 to 7.5.10
[\#768](#768)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump braces from 3.0.2 to 3.0.3
[\#773](#773)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump oidc-provider from 8.4.3 to 8.4.5
[\#720](#720)
([dependabot[bot]](https://github.com/apps/dependabot))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyaneshgouraw-okta gyaneshgouraw-okta gyaneshgouraw-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandan-bhat @gyaneshgouraw-okta