Adjusted nullability, added methods to public API

atifaziz · May 14, 2024 · 034bec1 · 034bec1
1 parent 512c3b8
commit 034bec1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/NCrontab.Tests/CrontabScheduleTests.cs b/NCrontab.Tests/CrontabScheduleTests.cs
@@ -57,7 +57,7 @@ public void CannotParseEmptyString()
         public void TryParseNullString()
 		{
             Assert.That(CrontabSchedule.TryParse(null!), Is.Null);
-            Assert.False(CrontabSchedule.TryParse(null, out var _));
+            Assert.False(CrontabSchedule.TryParse(string.Empty, out var _));
         }
 
         [Test]

diff --git a/NCrontab/CrontabSchedule.cs b/NCrontab/CrontabSchedule.cs
@@ -100,9 +100,11 @@ public static CrontabSchedule Parse(string expression, ParseOptions? options) =>
 
         public static CrontabSchedule? TryParse(string expression) => TryParse(expression, null);
 
-        public static bool TryParse(string expression, out CrontabSchedule schedule) => (schedule = TryParse(expression, null))!=null;
+        public static bool TryParse(string expression, out CrontabSchedule? schedule)
+            => (schedule = TryParse(expression, null))!=null;
 
-        public static bool TryParse(string expression, ParseOptions options, out CrontabSchedule schedule) => (schedule = TryParse(expression, options)) != null;
+        public static bool TryParse(string expression, ParseOptions options, out CrontabSchedule? schedule)
+            => (schedule = TryParse(expression, options)) != null;
 
         public static CrontabSchedule? TryParse(string expression, ParseOptions? options) =>
             TryParse(expression ?? string.Empty, options, v => v, _ => (CrontabSchedule?)null);

diff --git a/NCrontab/PublicAPI/net35/PublicAPI.Shipped.txt b/NCrontab/PublicAPI/net35/PublicAPI.Shipped.txt
@@ -48,3 +48,5 @@ static NCrontab.CrontabSchedule.TryParse(string! expression) -> NCrontab.Crontab
 static NCrontab.CrontabSchedule.TryParse(string! expression, NCrontab.CrontabSchedule.ParseOptions? options) -> NCrontab.CrontabSchedule?
 static NCrontab.CrontabSchedule.TryParse<T>(string! expression, NCrontab.CrontabSchedule.ParseOptions? options, System.Func<NCrontab.CrontabSchedule!, T>! valueSelector, System.Func<NCrontab.ExceptionProvider!, T>! errorSelector) -> T
 static NCrontab.CrontabSchedule.TryParse<T>(string! expression, System.Func<NCrontab.CrontabSchedule!, T>! valueSelector, System.Func<NCrontab.ExceptionProvider!, T>! errorSelector) -> T
+static NCrontab.CrontabSchedule.TryParse(string! expression, NCrontab.CrontabSchedule.ParseOptions! options, out NCrontab.CrontabSchedule? schedule) -> bool
+static NCrontab.CrontabSchedule.TryParse(string! expression, out NCrontab.CrontabSchedule? schedule) -> bool
diff --git a/NCrontab/PublicAPI/netstandard1.0/PublicAPI.Shipped.txt b/NCrontab/PublicAPI/netstandard1.0/PublicAPI.Shipped.txt
@@ -47,3 +47,5 @@ static NCrontab.CrontabSchedule.TryParse(string! expression) -> NCrontab.Crontab
 static NCrontab.CrontabSchedule.TryParse(string! expression, NCrontab.CrontabSchedule.ParseOptions? options) -> NCrontab.CrontabSchedule?
 static NCrontab.CrontabSchedule.TryParse<T>(string! expression, NCrontab.CrontabSchedule.ParseOptions? options, System.Func<NCrontab.CrontabSchedule!, T>! valueSelector, System.Func<NCrontab.ExceptionProvider!, T>! errorSelector) -> T
 static NCrontab.CrontabSchedule.TryParse<T>(string! expression, System.Func<NCrontab.CrontabSchedule!, T>! valueSelector, System.Func<NCrontab.ExceptionProvider!, T>! errorSelector) -> T
+static NCrontab.CrontabSchedule.TryParse(string! expression, NCrontab.CrontabSchedule.ParseOptions! options, out NCrontab.CrontabSchedule? schedule) -> bool
+static NCrontab.CrontabSchedule.TryParse(string! expression, out NCrontab.CrontabSchedule? schedule) -> bool
diff --git a/NCrontab/PublicAPI/netstandard2.0/PublicAPI.Shipped.txt b/NCrontab/PublicAPI/netstandard2.0/PublicAPI.Shipped.txt
@@ -47,3 +47,5 @@ static NCrontab.CrontabSchedule.TryParse(string! expression) -> NCrontab.Crontab
 static NCrontab.CrontabSchedule.TryParse(string! expression, NCrontab.CrontabSchedule.ParseOptions? options) -> NCrontab.CrontabSchedule?
 static NCrontab.CrontabSchedule.TryParse<T>(string! expression, NCrontab.CrontabSchedule.ParseOptions? options, System.Func<NCrontab.CrontabSchedule!, T>! valueSelector, System.Func<NCrontab.ExceptionProvider!, T>! errorSelector) -> T
 static NCrontab.CrontabSchedule.TryParse<T>(string! expression, System.Func<NCrontab.CrontabSchedule!, T>! valueSelector, System.Func<NCrontab.ExceptionProvider!, T>! errorSelector) -> T
+static NCrontab.CrontabSchedule.TryParse(string! expression, NCrontab.CrontabSchedule.ParseOptions! options, out NCrontab.CrontabSchedule? schedule) -> bool
+static NCrontab.CrontabSchedule.TryParse(string! expression, out NCrontab.CrontabSchedule? schedule) -> bool