Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change require_right_margin default and update warning message #307

Merged
merged 4 commits into from
May 8, 2024

Conversation

camposandro
Copy link
Collaborator

Changes the crossmatch require_right_margin argument to be False, by default. It also updates the warning messages issued when the right catalog does not have a margin. Closes #296 and #297.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.05%. Comparing base (2b102a3) to head (7c749bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   99.05%   99.05%           
=======================================
  Files          41       41           
  Lines        1274     1274           
=======================================
  Hits         1262     1262           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 7, 2024

Before [2b102a3] After [0d5e3c0] Ratio Benchmark (Parameter)
499±4ms 504±2ms 1.01 benchmarks.time_create_midsize_catalog
3.26±0.01s 3.26±0.01s 1 benchmarks.time_create_large_catalog
6.48±0.4ms 6.42±0.3ms 0.99 benchmarks.time_box_filter_on_partition
36.5±0.4ms 36.1±0.5ms 0.99 benchmarks.time_kdtree_crossmatch
13.0±0.9ms 12.8±0.3ms 0.98 benchmarks.time_polygon_search

Click here to view all benchmarks.

@camposandro camposandro requested a review from delucchi-cmu May 7, 2024 19:49
@camposandro camposandro merged commit c06454c into main May 8, 2024
11 checks passed
@camposandro camposandro deleted the issue/296/set-require-margin-default branch May 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants