Merge pull request #39 from astronomy-commons/delucchi/pylint

Address pylint issues under /tests/

.github/workflows/linting.yml

@@ -30,6 +30,6 @@ jobs:
         pip install .[dev]
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
     - name: Analyze code with linter
-
       run: |
         pylint -rn -sn --recursive=y ./src --rcfile=./src/.pylintrc
+        pylint -rn -sn --recursive=y ./tests --rcfile=./tests/.pylintrc

tests/.pylintrc

@@ -426,6 +426,7 @@ disable=raw-checker-failed,
         redefined-outer-name,
         protected-access,
         missing-module-docstring,
+        missing-class-docstring,
         unnecessary-pass,
 
 # Enable the message, report, category or checker with the given id(s). You can

tests/conftest.py

@@ -13,7 +13,7 @@
 SMALL_SKY_ORDER1_DIR_NAME = "small_sky_order1"
 XMATCH_CORRECT_FILE = "xmatch_correct.csv"
 XMATCH_CORRECT_005_FILE = "xmatch_correct_0_005.csv"
-XMATCH_CORRECT_3n_2t_NO_MARGIN_FILE = "xmatch_correct_3n_2t_no_margin.csv"
+XMATCH_CORRECT_3N_2T_NO_MARGIN_FILE = "xmatch_correct_3n_2t_no_margin.csv"
 XMATCH_MOCK_FILE = "xmatch_mock.csv"
 TEST_DIR = os.path.dirname(__file__)
 
@@ -80,7 +80,7 @@ def xmatch_correct_005(small_sky_xmatch_dir):
 
 @pytest.fixture
 def xmatch_correct_3n_2t_no_margin(small_sky_xmatch_dir):
-    return pd.read_csv(os.path.join(small_sky_xmatch_dir, XMATCH_CORRECT_3n_2t_NO_MARGIN_FILE))
+    return pd.read_csv(os.path.join(small_sky_xmatch_dir, XMATCH_CORRECT_3N_2T_NO_MARGIN_FILE))
 
 
 @pytest.fixture

tests/lsdb/catalog/test_cone_search.py

@@ -6,13 +6,13 @@ def test_cone_search_filters_correct_points(small_sky_order1_catalog):
     ra = 0
     dec = -80
     radius = 20
-    center_coord = SkyCoord(ra, dec, unit='deg')
+    center_coord = SkyCoord(ra, dec, unit="deg")
     cone_search_catalog = small_sky_order1_catalog.cone_search(ra, dec, radius).compute()
     print(len(cone_search_catalog))
     for _, row in small_sky_order1_catalog.compute().iterrows():
         row_ra = row[small_sky_order1_catalog.hc_structure.catalog_info.ra_column]
         row_dec = row[small_sky_order1_catalog.hc_structure.catalog_info.dec_column]
-        sep = SkyCoord(row_ra, row_dec, unit='deg').separation(center_coord)
+        sep = SkyCoord(row_ra, row_dec, unit="deg").separation(center_coord)
         if sep.degree <= radius:
             assert len(cone_search_catalog.loc[cone_search_catalog["id"] == row["id"]]) == 1
         else:

tests/lsdb/catalog/test_crossmatch.py

@@ -1,7 +1,4 @@
-from typing import Tuple
-
 import pandas as pd
-import hipscat as hc
 import pytest
 
 from lsdb.core.crossmatch.abstract_crossmatch_algorithm import AbstractCrossmatchAlgorithm
@@ -59,6 +56,7 @@ def test_wrong_suffixes(small_sky_catalog, small_sky_xmatch_catalog):
         small_sky_catalog.crossmatch(small_sky_xmatch_catalog, suffixes=("wrong",))
 
 
+# pylint: disable=too-few-public-methods
 class MockCrossmatchAlgorithm(AbstractCrossmatchAlgorithm):
     def crossmatch(self, mock_results: pd.DataFrame = None):
         left_reset = self.left.reset_index(drop=True)