Remove legacy API call to generate token #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 98.33% 98.33% -0.01%
==========================================
Files 94 94
Lines 4637 4635 -2
==========================================
- Hits 4560 4558 -2
Misses 77 77 ☔ View full report in Codecov by Sentry. |
pankajastro
force-pushed
the
remove_astro_deprecated_api_keys
branch
from
2e59f64 to
9de50dc
Compare
pankajastro
requested review from
phanikumv,
pankajkoti,
Lee-W,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
pankajastro
commented
Feb 21, 2024
Comment on lines
-131
to
-138
| self.hook = HttpHook( | ||
| method=self.method, | ||
| http_conn_id=self.http_conn_id, | ||
| tcp_keep_alive=self.tcp_keep_alive, | ||
| tcp_keep_alive_idle=self.tcp_keep_alive_idle, | ||
| tcp_keep_alive_count=self.tcp_keep_alive_count, | ||
| tcp_keep_alive_interval=self.tcp_keep_alive_interval, | ||
| ) |
There was a problem hiding this comment.
I'm not considering this a breaking change since I strongly feel this sensor is internal to Astro.
phanikumv
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1461