-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate RedshiftDeleteClusterOperatorAsync, RedshiftPauseClusterOperatorAsync and RedshiftResumeClusterOperatorAsync operators #1399
Conversation
RedshiftDeleteClusterOperatorAsync
, RedshiftPauseClusterOperatorAsync
and RedshiftResumeClusterOperatorAsync
operators
RedshiftDeleteClusterOperatorAsync
, RedshiftPauseClusterOperatorAsync
and RedshiftResumeClusterOperatorAsync
operators8228d8f
to
0bccb32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try running our example DAGs once against this PR to ensure they run fine, please?
Sure. I forget to make it a draft. This is blocked by the PR I mentioned in the description. |
675a0d4
to
9bb5e34
Compare
f0ccfa4
to
b37bf19
Compare
Already test it with 8.16.0rc1 on astro cloud and everything works fine |
ff10f78
to
44a27b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1399 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 91 91
Lines 5268 5214 -54
=======================================
- Hits 5184 5131 -53
+ Misses 84 83 -1 ☔ View full report in Codecov by Sentry. |
293b2fb
to
161e822
Compare
161e822
to
4f4fb4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed
Deprecate redshift_cluster operators and fallback to their OSS counter part
with
deferrable=True`This is blocked by the release of https://github.com/apache/airflow/pull/36416 as the logic of checking cluster_state before deferring has not yet been contributed back.
Why this change
Most of the logic of these operators has been contributed back to OSS airflow