Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RedshiftDeleteClusterOperatorAsync, RedshiftPauseClusterOperatorAsync and RedshiftResumeClusterOperatorAsync operators #1399

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Dec 25, 2023

What's changed

Deprecate redshift_cluster operators and fallback to their OSS counter partwithdeferrable=True`

This is blocked by the release of https://github.com/apache/airflow/pull/36416 as the logic of checking cluster_state before deferring has not yet been contributed back.

Why this change

Most of the logic of these operators has been contributed back to OSS airflow

@Lee-W Lee-W changed the title Deprecate redshift cluster operators Deprecate RedshiftDeleteClusterOperatorAsync, RedshiftPauseClusterOperatorAsync and RedshiftResumeClusterOperatorAsync operators Dec 25, 2023
@Lee-W Lee-W changed the title Deprecate RedshiftDeleteClusterOperatorAsync, RedshiftPauseClusterOperatorAsync and RedshiftResumeClusterOperatorAsync operators Deprecate RedshiftDeleteClusterOperatorAsync, RedshiftPauseClusterOperatorAsync and RedshiftResumeClusterOperatorAsync operators Dec 25, 2023
@Lee-W Lee-W force-pushed the deprecate-redshift-cluster-operators branch from 8228d8f to 0bccb32 Compare December 25, 2023 10:30
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we try running our example DAGs once against this PR to ensure they run fine, please?

@Lee-W
Copy link
Contributor Author

Lee-W commented Dec 26, 2023

Could we try running our example DAGs once against this PR to ensure they run fine, please?

Sure. I forget to make it a draft. This is blocked by the PR I mentioned in the description.

@Lee-W
Copy link
Contributor Author

Lee-W commented Jan 10, 2024

Already test it with 8.16.0rc1 on astro cloud and everything works fine

@Lee-W Lee-W force-pushed the deprecate-redshift-cluster-operators branch 4 times, most recently from ff10f78 to 44a27b6 Compare January 11, 2024 11:13
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4208201) 98.40% compared to head (4f4fb4e) 98.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files          91       91           
  Lines        5268     5214   -54     
=======================================
- Hits         5184     5131   -53     
+ Misses         84       83    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W marked this pull request as ready for review January 12, 2024 09:22
@Lee-W Lee-W force-pushed the deprecate-redshift-cluster-operators branch 2 times, most recently from 293b2fb to 161e822 Compare January 16, 2024 03:53
@Lee-W Lee-W requested a review from pankajkoti January 16, 2024 06:58
@phanikumv phanikumv force-pushed the deprecate-redshift-cluster-operators branch from 161e822 to 4f4fb4e Compare January 17, 2024 06:36
Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lee-W Lee-W merged commit 1fa825f into main Jan 17, 2024
11 checks passed
@Lee-W Lee-W deleted the deprecate-redshift-cluster-operators branch January 17, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants