Return job_id from execute() and execute_complete() method in SubmitAnyscaleJob #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
venkatajagannath
temporarily deployed
to
internal
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 96.41% 96.44% +0.02%
==========================================
Files 4 4
Lines 279 281 +2
==========================================
+ Hits 269 271 +2
Misses 10 10 ☔ View full report in Codecov by Sentry. |
phanikumv
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per customer feedback, they would like to use the job_id in downstream tasks for tracking.
This PR returns the job_id from both the execute() and the execute_complete() methods. We also updated the associated unit test