-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime spinner issues #1779
Conversation
@pritt20 I still see the issue if I shrink my terminal down smaller than the first line. I wonder how hard it would be to somehow hook into the terminal size and wrap the text to multiple lines accordingly. Or maybe cut off the line and end with |
Thanks @schnie ! Yeah, I am able to reproduce it as well. I'll try other options to see if we can include terminal size dynamically. |
rebase with main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM, left some minor nits, but approving ahead of time
Co-authored-by: Pritesh Arora <[email protected]> Co-authored-by: Greg Neiheisel <[email protected]>
Description
We observed couple of issues related to progress spinner in Astro CLI during setting up local project:
Screenshot:
The changes in this PR address above issues and provides user meaningful information as we set-up local astro-project.
🎟 Issue(s)
Related #XXX
🧪 Functional Testing
Tested the changes locally, please find below screen recording for ref:
Screen.Recording.2025-01-17.at.1.58.22.AM.mov
📋 Checklist
make test
before taking out of draftmake lint
before taking out of draft