Dev updates 2024-12-12 #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishkarajgi
approved these changes
Dec 13, 2024
danielhoherd
added a commit
that referenced
this pull request
Dec 13, 2024
* Add ruff-format and apply it * rebuild python requirements * pre-commit autoupdate * Use latest k8s 1.31 * Make helm_template_generator.py match astronomer/astronomer version a lot more * Add k8s schema file
danielhoherd
added a commit
that referenced
this pull request
Dec 13, 2024
* Add ruff-format and apply it * rebuild python requirements * pre-commit autoupdate * Use latest k8s 1.31 * Make helm_template_generator.py match astronomer/astronomer version a lot more * Add k8s schema file
danielhoherd
added a commit
that referenced
this pull request
Dec 13, 2024
* Add ruff-format and apply it * rebuild python requirements * pre-commit autoupdate * Use latest k8s 1.31 * Make helm_template_generator.py match astronomer/astronomer version a lot more * Add k8s schema file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #550 I allegedly added
ruff-format, but somehow after applyingruff-formatchanges, the hook was left out of the commit.Changes included in this PR:
ruff-formatpre-commit hook and apply it (only changed whitespace)pre-commit autoupdaterender_k8s_object()functionRelated Issues
NA, KTLO work, but these issues were found while debugging an inconsistent behavior with
helm_template_generator()while working on https://github.com/astronomer/issues/issues/6789Testing
As long as tests are passing this is good.
Merging
This should be merged everywhere.