Add custom projection support #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it, add support for custom Projections
|
This is a bit overkill in my opinion, hope you're ok with the planar camera implementation. Otherwise, please use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #45, this adds support for custom projections. All required projection functionality is made accessible through the
Projectiontrait, whichProjectionTypenow implements. AdditionallyProjectionTypehas a thirdCustomvariant added to it which wraps a boxedProjectionto store and delegate to user-defined projections.I still have some cleanup I would like to do on
Camera, hence this is a draft PR at the moment. Also, it may be good to moveProjectionand related types into a separate module.