Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the way jquery loads #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed the way jquery loads #6

wants to merge 2 commits into from

Conversation

coderaiser
Copy link
Contributor

JQuery changes:

  1. Added google cdn url to improve speed.
  2. Updated version 1.7.1 -> 2.0.0.
  3. Removed from require(demo.js, util.js, std.keyboard.js).

@asmblah
Copy link
Owner

asmblah commented May 1, 2013

Hi coderaiser,

Thanks, but I think I prefer pulling in the jquery dependency via AMD rather than using the global reference - just feels cleaner. The Google CDN would be good to use, but needs a proper fallback implementation adding to Modular first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coderaiser @asmblah