Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Quick Links home view section #11373

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Jan 10, 2025

This PR resolves ONYX-1478

Description

This PR adds a quick links section to the home view.

Screen.Recording.2025-01-10.at.12.26.46.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add Quick Links home view section - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Jan 10, 2025
@MounirDhahri MounirDhahri marked this pull request as draft January 10, 2025 13:20
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 🌟 🌟

href: string
}

export const Pills: Array<QuickLinkPill> = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is somewhat important, I believe it could also be placed above the component 🤷

Suggested change
export const Pills: Array<QuickLinkPill> = [
export const PILLS: Array<QuickLinkPill> = [

Comment on lines +1514 to +1516
screenOptions: {
headerShown: false,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants