Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use bidder stored on sale for determining if credit card info or creating bidder info is required. #11369

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oxaudo
Copy link
Member

@oxaudo oxaudo commented Jan 9, 2025

This PR comes from investigating https://artsyproduct.atlassian.net/browse/EMI-2224. The issue described there is not exactly the same but in a process discovered the bug where user is required to reenter the credit card after their bid has been outbid right away

Description

Following the pattern currently present in Force and reading the bidding info from sale on sale_artwork. Seems like there authenticatedUser is automatically applied to the data returns properly.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@oxaudo oxaudo requested a review from MrSltun January 9, 2025 22:40
@oxaudo oxaudo self-assigned this Jan 9, 2025
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jan 9, 2025

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against 4243ee2

Copy link
Member

@MrSltun MrSltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! 🌟 We just might need to do a little cleanup and fix the tests!
Thank you Oksana!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants