Assorted LLVM inspired changes #930
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
September 22, 2024 15:54
Simply split the expressions.
Help the compiler in finding mismatches.
Avoid implicit integer to pointer conversion.
Avoid uninitialized member variable.
Clarifies the intended scope of the functions.
Enable compilers to move temporary variables into the constructor.
Avoid C-style cast.
Avoid leaking file descriptor via potential sibling threads.
The bounds check is done explicitly in the line before.
gethostname() might not NUL-terminate the passed buffer on truncation.
Avoid implicit conversions; these might be unwanted or truncating.
Hide class internals.
Avoid uninitialized members.
Follow the RAII paradigm and define all 5 special class function if any of them has a non-default implementation. Avoids duplicate destruction or other unwanted effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted code tweaks reported by clang and clang-tidy.
Not behavior change intended.
See individual commits for information.