Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(anta.tests): Cleaning up STUN tests module #934

Merged
merged 16 commits into from
Dec 5, 2024
Merged

fix(anta.tests): Cleaning up STUN tests module #934

merged 16 commits into from
Dec 5, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Refactoring STUN tests module to address the following issues:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

@vitthalmagadum vitthalmagadum mentioned this pull request Nov 25, 2024
Open
32 tasks
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #934 will not alter performance

Comparing vitthalmagadum:feat/stun (a2c1428) with main (cc10fb0)

Summary

✅ 8 untouched benchmarks

gmuloc
gmuloc requested changes Nov 25, 2024
View reviewed changes
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
@vitthalmagadum vitthalmagadum marked this pull request as draft November 26, 2024 13:25
@vitthalmagadum vitthalmagadum marked this pull request as ready for review November 28, 2024 06:14
gmuloc
gmuloc reviewed Nov 29, 2024
View reviewed changes
anta/tests/stun.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Nov 29, 2024
View reviewed changes
anta/tests/stun.py Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Nov 29, 2024
View reviewed changes
anta/tests/stun.py Outdated Show resolved Hide resolved
gmuloc
gmuloc requested changes Nov 29, 2024
View reviewed changes
anta/input_models/stun.py Outdated Show resolved Hide resolved
@vitthalmagadum vitthalmagadum requested a review from gmuloc December 2, 2024 11:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc mentioned this pull request Dec 3, 2024
Merged
6 tasks
gmuloc
gmuloc reviewed Dec 5, 2024
View reviewed changes
anta/tests/stun.py Outdated Show resolved Hide resolved
gmuloc
gmuloc approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI and pre-commit are happy

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gmuloc gmuloc merged commit 0c32b83 into aristanetworks:main Dec 5, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@carl-baillargeon carl-baillargeon Awaiting requested review from carl-baillargeon

Assignees

@vitthalmagadum vitthalmagadum

Labels
rn: fix(anta.tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitthalmagadum @gmuloc