Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): support select single resource to sync #21587

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Jan 21, 2025

Fixes #21578

Some resources are not listed in the sync panel, making them unavailable for selection using query parameters. However, we can locate these resources' parentRef and, based on that information, identify and sync the target resources effectively.

Before

single-before.mp4

After

sync-after.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@linghaoSu linghaoSu requested a review from a team as a code owner January 21, 2025 02:42
Copy link

bunnyshell bot commented Jan 21, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@linghaoSu linghaoSu force-pushed the fix/sync-single-resource branch from f438af2 to e30cea1 Compare January 21, 2025 08:04
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I suggested a slightly different approach here: #21578 (comment)

@linghaoSu linghaoSu force-pushed the fix/sync-single-resource branch from e30cea1 to 1c991ef Compare January 22, 2025 06:50
@linghaoSu linghaoSu force-pushed the fix/sync-single-resource branch from 1c991ef to 29d1a63 Compare January 22, 2025 06:51
@linghaoSu
Copy link
Member Author

Thanks for the PR! I suggested a slightly different approach here: #21578 (comment)

Thank you for the review! I’ve implemented the suggested approach. Could you please review it again? Your feedback is much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource-Specific Sync in ArgoCD UI Does Not Limit to Selected Resource
2 participants