ci: install terraform before running generate #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-technat
requested review from
oboukili,
onematchfox,
blakepettersson and
mkilchhofer
as code owners
Signed-off-by: Nathanael Liechti <[email protected]>
the-technat
force-pushed
the
ci/terraform-binary
branch
from
bce32fc to
6896004
Compare
mkilchhofer
approved these changes
Jan 8, 2025
onematchfox
approved these changes
Jan 8, 2025
|
@onematchfox good question, probably the github runners had a Terraform binary installed by default. Anyway, the scaffold repo does this too: https://github.com/hashicorp/terraform-provider-scaffolding-framework/blob/main/.github/workflows/test.yml#L45-L48 |
|
Complete nit... Not that this repo requires/enforces commit message semantics to begin with but, for future reference, |
mkilchhofer
changed the title
the-technat
added a commit
to chidambaram27/terraform-provider-argocd
that referenced
this pull request
Jan 9, 2025
Signed-off-by: Nathanael Liechti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CI tests which are currently failing.