Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to Return Similarity Scores Along with Records #5778

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

Saikiranbonu1661
Copy link
Contributor

Description

Closes #5777

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Passes similar param in query method while fetching records and could see returning similarity score.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon self-requested a review January 10, 2025 09:27
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Saikiranbonu1661

I pushed some changes to keep the backward compatibility as much as possible. The similarity score will be returned only when a similarity search is applied. The rest of the searches/filters won't return any score.

@frascuchon frascuchon force-pushed the bugfix_handling_score branch from c6c616d to 02e0d37 Compare January 20, 2025 13:28
@frascuchon frascuchon added this to the v2.7.0 milestone Jan 20, 2025
@frascuchon frascuchon merged commit dc3deab into argilla-io:develop Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get score in Similarity search
2 participants