Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] remove name validations for dataset workspaces and usernames #5575

Conversation

frascuchon
Copy link
Member

Description

This PR removes name pattern validations for datasets, workspaces, and users.

Type of change

  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon marked this pull request as draft October 7, 2024 09:04
@frascuchon frascuchon marked this pull request as ready for review October 7, 2024 10:35
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (83996fe) to head (5ebb86e).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5575      +/-   ##
===========================================
- Coverage    91.30%   91.22%   -0.08%     
===========================================
  Files          145      145              
  Lines         6037     6030       -7     
===========================================
- Hits          5512     5501      -11     
- Misses         525      529       +4     
Flag Coverage Δ
argilla-server 91.22% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon merged commit 485f3ff into develop Oct 7, 2024
5 of 6 checks passed
@frascuchon frascuchon deleted the refactor/remove-name-validations-for-dataset-workspaces-and-usernames branch October 7, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants