Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: validate custom fields when creating or updating settings #5563

Conversation

frascuchon
Copy link
Member

Description

This PR adds template validation for custom fields. The validation is a general step when validating settings (settings.validate). The settings.validate method is called before creating or updating the settings, which adds more flexibility to the validations we want to include.

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from burtenshaw October 3, 2024 09:47
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough to cover basic string/non-string errors.

@frascuchon frascuchon merged commit 0b4683b into releases/2.3.0 Oct 3, 2024
6 of 7 checks passed
@frascuchon frascuchon deleted the refactor/validate-custom-fields-when-creating-or-updating-settings branch October 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants