-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set CREATOR_USER_ID to avoid difficulties with creation in orga… #5556
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5556 +/- ##
========================================
Coverage 91.28% 91.28%
========================================
Files 145 145
Lines 6025 6037 +12
========================================
+ Hits 5500 5511 +11
- Misses 525 526 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DEFAULT_PASSWORD=$(pwgen -s 16 1) | ||
export PASSWORD="${PASSWORD:-$DEFAULT_PASSWORD}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the implications of this change. Could we remove this from this PR and add it in the context of deploy_on_spaces
feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frascuchon I don't think this has implications except for always creating a user with a random password (this will be printed in the logs), if no password is provided. Otherwise, no explicit user will be created, which feels weird to me in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frascuchon I updated the docs for spaces specifically because it only makes sense there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidberenstein1957 I left some suggestions since the previous paragraph also refers to the space creator. Maybe combining them would be simpler to understand.
argilla/docs/getting_started/how-to-configure-argilla-on-huggingface.md
Outdated
Show resolved
Hide resolved
argilla/docs/getting_started/how-to-configure-argilla-on-huggingface.md
Outdated
Show resolved
Hide resolved
…ngface.md Co-authored-by: Paco Aranda <[email protected]>
…ngface.md Co-authored-by: Paco Aranda <[email protected]>
…nisation
Description
User
CREATOR_USER_ID
with this API https://huggingface.co/api/users/davidberenstein1957/overviewType of change
How Has This Been Tested
Checklist