Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set CREATOR_USER_ID to avoid difficulties with creation in orga… #5556

Merged
merged 15 commits into from
Oct 7, 2024

Conversation

davidberenstein1957
Copy link
Member

@davidberenstein1957 davidberenstein1957 commented Oct 1, 2024

…nisation

Description

User CREATOR_USER_ID with this API https://huggingface.co/api/users/davidberenstein1957/overview

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@davidberenstein1957 davidberenstein1957 marked this pull request as ready for review October 2, 2024 09:00
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (9677435) to head (3a10183).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5556   +/-   ##
========================================
  Coverage    91.28%   91.28%           
========================================
  Files          145      145           
  Lines         6025     6037   +12     
========================================
+ Hits          5500     5511   +11     
- Misses         525      526    +1     
Flag Coverage Δ
argilla-server 91.28% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidberenstein1957
Copy link
Member Author

davidberenstein1957 commented Oct 2, 2024

Comment on lines +15 to +16
DEFAULT_PASSWORD=$(pwgen -s 16 1)
export PASSWORD="${PASSWORD:-$DEFAULT_PASSWORD}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the implications of this change. Could we remove this from this PR and add it in the context of deploy_on_spaces feature?

Copy link
Member Author

@davidberenstein1957 davidberenstein1957 Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frascuchon I don't think this has implications except for always creating a user with a random password (this will be printed in the logs), if no password is provided. Otherwise, no explicit user will be created, which feels weird to me in general.

Copy link
Member

@frascuchon frascuchon Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so maybe we should add some info about this in the docs (here or here)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frascuchon I updated the docs for spaces specifically because it only makes sense there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidberenstein1957 I left some suggestions since the previous paragraph also refers to the space creator. Maybe combining them would be simpler to understand.

@frascuchon frascuchon self-requested a review October 7, 2024 10:32
@davidberenstein1957 davidberenstein1957 merged commit 83996fe into develop Oct 7, 2024
6 of 8 checks passed
@davidberenstein1957 davidberenstein1957 deleted the feat/oauth_flow_creator_id branch October 7, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants