Enhancement/improve-error-messaging-for-role-forbidden

[burtenshaw]

Description

Closes #<issue_number>

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (change restructuring the codebase without changing functionality)
• Improvement (change adding some improvement to an existing functionality)
• Documentation update

How Has This Been Tested

Checklist

• I added relevant documentation
• I followed the style guidelines of this project
• I did a self-review of my code
• I made corresponding changes to the documentation
• I confirm My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

[davidberenstein1957]

I think this works great. I believe this is specifically for dataset creation but shouldn't we be covering the basic scenario of rg.Argilla(api_url="correct", api_key="wrong") as well?

[burtenshaw]

I think this works great. I believe this is specifically for dataset creation but shouldn't we be covering the basic scenario of rg.Argilla(api_url="correct", api_key="wrong") as well?

I've improved that with changes to the message in argilla/src/argilla/_exceptions/_api.py . We also already have a validation message in argilla/src/argilla/_exceptions/_client.py that says: ""Credentials (api_key and/or api_url) are invalid"".

[davidberenstein1957]

I think this works great. I believe this is specifically for dataset creation but shouldn't we be covering the basic scenario of rg.Argilla(api_url="correct", api_key="wrong") as well?

I've improved that with changes to the message in argilla/src/argilla/_exceptions/_api.py . We also already have a validation message in argilla/src/argilla/_exceptions/_client.py that says: ""Credentials (api_key and/or api_url) are invalid"".

but perhaps it would be nice if we could also share a similar message, urging the user to go to my-settings with their owner account?