Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/review docker readme #5325

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

frascuchon
Copy link
Member

Description

Closes #<issue_number>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link

Docs for this PR have been deployed hidden from versioning: https://argilla-io.github.io/argilla/docs_review-docker-readme

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (2774686) to head (9a1a4c6).
Report is 36 commits behind head on docs/onboarding_improvement.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           docs/onboarding_improvement    #5325   +/-   ##
============================================================
  Coverage                        91.12%   91.12%           
============================================================
  Files                              139      139           
  Lines                             5748     5748           
============================================================
  Hits                              5238     5238           
  Misses                             510      510           
Flag Coverage Δ
argilla-server 91.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon added this to the v2.0.0 milestone Jul 29, 2024
Copy link
Member

@dvsrepo dvsrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some minor suggestions

Co-authored-by: Daniel Vila Suero <[email protected]>
@frascuchon frascuchon merged commit 9feb7b1 into docs/onboarding_improvement Jul 29, 2024
2 of 3 checks passed
@frascuchon frascuchon deleted the docs/review-docker-readme branch July 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants