Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] argilla: align usage of questions #5240

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

frascuchon
Copy link
Member

Description

This PR reviews and aligns the questions' usage with the rest of the settings. Now, questions can be accessed as the rest of the settings:

settings.questions["name"]

Note: Updating questions for existing datasets is still not possible. But we can add questions to settings before creating the dataset:

settings.questions.add(...)
dataset = rg.Dataset(..., settings=settings).create()

Closes #5231

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM, perhaps we should double check the docs?

@frascuchon
Copy link
Member Author

LFTM, perhaps we should double check the docs?

@nataliaElv is already working on this here

@frascuchon frascuchon merged commit c8bfbc0 into develop Jul 18, 2024
7 checks passed
@frascuchon frascuchon deleted the feat/argilla/align-usage-of-questions branch July 18, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Access questions by name
2 participants