docs: add from diskto disk methods to docs #5186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs for this PR have been deployed hidden from versioning: https://argilla-io.github.io/argilla/docs_5178-docs-add-from_diskto_disk-methods-to-docs |
|
@sdiazlor, looking good. Would you be able to review the line length of code in guides too? sometimes it isn't easy to read because lines are too long. Also, along with the release of the |
dvsrepo
reviewed
Jul 10, 2024
|
|
||
| dataset_to_save = client.datasets(name="my_dataset") | ||
|
|
||
| dataset_saved = dataset_to_save.to_disk(path="/path/empty-directory") |
There was a problem hiding this comment.
What does to_disk() returns? I'd use a more precise name for the variable and even add a sentence in the description on top about it. I also think is worth mentioning that we recommend creating an empty directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Closes #5178
Type of change
How Has This Been Tested
Checklist