-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] hub integration with dataset and configuration #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re ingestion loop
…with refactor and tqdm and exceptions
for more information, see https://pre-commit.ci
Reviewing and improving records.log Instead of: <img width="1335" alt="Captura de pantalla 2024-06-26 a las 12 48 14" src="https://github.com/argilla-io/argilla/assets/2518789/02283f4c-fe6a-464f-96b3-36853e6c7622"> for 50 records, records.log can log 1000: <img width="870" alt="Captura de pantalla 2024-06-26 a las 12 48 57" src="https://github.com/argilla-io/argilla/assets/2518789/d20f0469-0b33-427e-aa12-b4b7e1d40cd1">
…o/argilla into spike/mapping-to-tuple
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…o/argilla into spike/mapping-to-tuple
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…argilla into feat/hub-integration
…argilla into feat/hub-integration
…argilla into feat/hub-integration
frascuchon
reviewed
Jul 11, 2024
frascuchon
reviewed
Jul 11, 2024
frascuchon
reviewed
Jul 11, 2024
frascuchon
reviewed
Jul 11, 2024
frascuchon
reviewed
Jul 11, 2024
Co-authored-by: Paco Aranda <[email protected]>
Co-authored-by: Paco Aranda <[email protected]>
for more information, see https://pre-commit.ci
Wauplin
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final review from my side. Integration looks good to me! ✔️
Left 2 small comments regarding future maintenance.
frascuchon
approved these changes
Jul 12, 2024
These PR introduces a new guide on exporting datasets and/or their records. It moves content out of the current 'query and export' guide, and creates a soley export guide. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel Vila Suero <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental WIP pr to get feedback on the approach. I've migrated the code out of the v1 argilla client, and reimplemented for v2 changes. It would be great to get feedback on issues like this:
huggingface_hub
. I like the decorator used in the v1 client.Here's a dataset that I pushed. Still uses default readme from v1:
https://huggingface.co/datasets/burtenshaw/test-argilla-dataset
To test this implementation do: