[FEATURE] Prepare new argilla package #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will help to move all related argilla refs to argilla-v1 by defining a simpler workflow to build (and publish) the `argilla(-v1)` package. The new workflow will only run the unit tests. Some of the workflow names have been reviewed, and some others have been removed.
…lla` (#4975) <!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This is a WIP PR to evaluate using the new argilla SDK as the `argilla` module in Python. The changes included in this PR do not affect the current `argilla-sdk` project. I've created a brand new `argilla` project quite simple. The project `argilla` manages dependencies for both SDK versions under the same package. Having this new `argilla` package is not a requirement. We can rename the current `argilla-sdk` to `argilla` and include the `argilla-v1` dependency and the `v1` module. We've already discussed having a bundle package for adding and managing extensions or contribs packages through argilla: ```bash pip install argilla[extensions] pip install argilla[contrib] ``` instead of ```bash pip install argilla-extensions pip install argilla-contrib ```` But I think this can be tackled once we have more packages other than argilla. So, my proposal for the v2 release is to move `argilla-sdk` to the official `argilla` project. ## Update The decision will be to rename `argilla-sdk` to `argilla` and expose the `v1` as a dependency.. See PR #4975 to see some of this work. Refs: #4889 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5006-ki24f765kq-no.a.run.app |
frascuchon
force-pushed
the
feat/prepare-new-argilla-package
branch
from
efad3ec to
ee664fa
Compare
10 tasks
frascuchon
added a commit
that referenced
this pull request
Jun 13, 2024
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description After resolving conflicts in #5006 I found errors on some file conflicts resolution. This PR fixes them. **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies several changes to achieve the new argilla project structure:
argilla-sdkbecomes the newargillaproject.argillaproject has been moved toargilla-v1(and its package)Closes #4889
Closes #4888
Closes #4828
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)