fix: block plan production when no case found (#349)

arextest · Aug 22, 2024 · 9df9587 · 9df9587
1 parent e187235
commit 9df9587
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/arex-schedule-web-api/pom.xml b/arex-schedule-web-api/pom.xml
@@ -136,7 +136,7 @@
   <parent>
     <artifactId>arex-schedule-parent</artifactId>
     <groupId>com.arextest</groupId>
-    <version>1.2.14</version>
+    <version>1.2.15</version>
   </parent>
 
   <profiles>
@@ -338,5 +338,5 @@
       </properties>
     </profile>
   </profiles>
-  <version>1.2.14</version>
+  <version>1.2.15</version>
 </project>
diff --git a/arex-schedule-web-api/src/main/java/com/arextest/schedule/service/LocalReplayService.java b/arex-schedule-web-api/src/main/java/com/arextest/schedule/service/LocalReplayService.java
@@ -459,13 +459,14 @@ private Pair<ReplayPlan, CommonResponse> buildReplayPlan(BuildReplayPlanRequest
       return Pair.of(null, CommonResponse.badResponse("save replay action error, " + replayPlan,
           new BuildReplayPlanResponse(BuildReplayFailReasonEnum.DB_ERROR)));
     }
-    progressEvent.onReplayPlanCreated(replayPlan);
 
     planConsumePrepareService.preparePlan(replayPlan);
     if (replayPlan.getCaseTotalCount() == 0) {
       return Pair.of(null, CommonResponse.badResponse("No case found in selected range"));
     }
 
+    progressEvent.onReplayPlanCreated(replayPlan);
+
     replayPlan.setExecutionContexts(planExecutionContextProvider.buildContext(replayPlan));
     if (CollectionUtils.isEmpty(replayPlan.getExecutionContexts())) {
       replayPlan.setErrorMessage("Got empty execution context");

diff --git a/pom.xml b/pom.xml
@@ -320,5 +320,5 @@
     <url>https://github.com/arextest/arex-replay-schedule</url>
   </scm>
   <url>https://github.com/arextest/arex-replay-schedule</url>
-  <version>1.2.14</version>
+  <version>1.2.15</version>
 </project>