Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General fixes and maintenance #202

Merged
merged 4 commits into from
Dec 14, 2023
Merged

General fixes and maintenance #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
934bf58
Fix Broken Test EntryPointServiceExecuteAsync
KyleMcMaster Dec 14, 2023
200e3f1
change String to string
KyleMcMaster Dec 14, 2023
3fb9ae7
Remove unused packages
KyleMcMaster Dec 14, 2023
eb20037
Update editorconfig
KyleMcMaster Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ dotnet_style_prefer_compound_assignment = true:suggestion
dotnet_style_prefer_simplified_interpolation = true:suggestion
dotnet_style_namespace_match_folder = true:suggestion
###############################
# IDE EditorConfig Settings #
###############################
# IDE0005: Using directive is unnecessary.
dotnet_diagnostic.IDE0005.severity = warning
###############################
# C# Coding Conventions #
###############################
[*.cs]
Expand Down
7 changes: 0 additions & 7 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@
<PackageVersion Include="Autofac" Version="6.4.0" />
<PackageVersion Include="Autofac.Extensions.DependencyInjection" Version="8.0.0" />
<PackageVersion Include="coverlet.collector" Version="6.0.0" />
<PackageVersion Include="FastEndpoints" Version="5.3.2" />
<PackageVersion Include="FastEndpoints.ApiExplorer" Version="2.0.1" />
<PackageVersion Include="FastEndpoints.Swagger" Version="5.2.1" />
<PackageVersion Include="FastEndpoints.Swagger.Swashbuckle" Version="2.0.1" />
<PackageVersion Include="MediatR" Version="11.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="8.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="7.0.0" />
<PackageVersion Include="Microsoft.AspNetCore.Mvc.Testing" Version="7.0.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.0" />
<PackageVersion Include="Microsoft.EntityFrameworkCore.InMemory" Version="7.0.0" />
Expand All @@ -36,10 +31,8 @@
<PackageVersion Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.19.5" />
<PackageVersion Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="7.0.0" />
<PackageVersion Include="Moq" Version="4.18.4" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.2-beta2" />
<PackageVersion Include="ReportGenerator" Version="5.1.12" />
<PackageVersion Include="Serilog.AspNetCore" Version="6.1.0-dev-00285" />
<PackageVersion Include="Serilog.Sinks.ApplicationInsights" Version="4.0.1-dev-00040" />
<PackageVersion Include="SQLite" Version="3.13.0" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="6.4.0" />
<PackageVersion Include="Swashbuckle.AspNetCore.Annotations" Version="6.4.0" />
Expand Down
2 changes: 1 addition & 1 deletion src/CleanArchitecture.Core/Services/EntryPointService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public async Task ExecuteAsync()

// read from the queue
string message = await _queueReceiver.GetMessageFromQueue(_settings.ReceivingQueueName);
if (String.IsNullOrEmpty(message)) return;
if (string.IsNullOrEmpty(message)) return;

// check 1 URL in the message
var statusHistory = await _urlStatusChecker.CheckUrlAsync(message, "");
Expand Down
3 changes: 2 additions & 1 deletion tests/CleanArchitecture.UnitTests/Core/EntryPointServiceExecuteAsync.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ private static (EntryPointService, Mock<ILoggerAdapter<EntryPointService>>, Mock
};
var queueReceiver = new Mock<IQueueReceiver>();
var serviceLocator = new Mock<IServiceLocator>();
var urlStatusChecker = new Mock<IUrlStatusChecker>();

// maybe a tuple later on
var repository = SetupCreateScope(serviceLocator);

var service = new EntryPointService(logger.Object, settings, queueReceiver.Object, null, serviceLocator.Object, null);
var service = new EntryPointService(logger.Object, settings, queueReceiver.Object, serviceLocator.Object, urlStatusChecker.Object);
return (service, logger, queueReceiver, serviceLocator, repository);
}

Expand Down