Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes full-screen overlay for frontend errors when running webpack development server. #10224 #10225

Merged

Conversation

chrabyrd
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Removes full-screen overlay for frontend errors when running webpack development server.

Issues Solved

#10224

@chrabyrd chrabyrd marked this pull request as ready for review October 31, 2023 21:26
@chrabyrd chrabyrd changed the title updates webpack config #10224 Removes full-screen overlay for frontend errors when running webpack development server. #10224 Oct 31, 2023
@jacobtylerwalls
Copy link
Member

Just wondering about the rationale, is it because we demo with the development server?

@chrabyrd
Copy link
Contributor Author

Just wondering about the rationale, is it because we demo with the development server?

Yes, that and the overlays can be a hinderance for development and don't offer much gain otherwise. It's not surfacing any legitimate errors that don't already appear in the dev console.

Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed upgrading an Arches implementation to 7.5: without this change (which is okay by me!) we would have needed to increase the lower bound on webpack-dev-server to 4.13.0, which is where runtimeErrors was introduced.

I almost PR'd that until I realized we're probably just going to merge this instead. LGTM

Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit d519c1d into dev/7.5.x Nov 3, 2023
1 check passed
@chiatt chiatt deleted the 10224-cbyrd-remove-error-overlay-in-yarn-dev-server branch November 3, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants