Fix race condition in resource-instance-select.js #10210

[jacobtylerwalls]

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

If a document has >1 resource instance select widgets, they may both try to initialize select2 widgets, which manage references to the DOM and cannot handle parallel init'ing.

Issues Solved

Fixes #10210

Sourced to a36a946.

Checklist

• Unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Ticket Background

• Sponsored by:
• Found by: @
• Tested by: @
• Designed by: @

Testing instructions

Ensure that icons still appear in the resource instance select widget per #8305.

[aj-he]

👋 @jacobtylerwalls

I can't see any issues with this change, the behaviour seems to be fine.

I have noticed however that the graph icons are no longer showing against the resources that come up in the list. I only get the fa fa-question, no matter what I set.

I have tracked this to the following line, where the Graph objects are turned into a dict -

arches/arches/app/views/api.py

Line 359 in 9aea9d1

graph = JSONSerializer().serializeToPython(graph, sort_keys=False, exclude=["is_editable", "functions"] + exclusions)

After this line, the iconclass property no longer has a value, so this needs to be fixed. I'll pop some screen shots below.

[aj-he]

Resources no longer have their model icons...

The Graph objects retrieved from the DB by graph api has the value...

... but this is then stripped out by the JSONSerializer...

[jacobtylerwalls]

Thanks for flagging that, I'll take a look.

[jacobtylerwalls]

Hey @aj-he I can't reproduce that myself, I still have icons in the UI and I when I break at the line in your screenshot, I still have a graphid:

This is the value of exclusions:

['cards', 'domain_connections', 'edges', 'nodegroups', 'nodes', 'widgets']

Is yours different?

For me, findings were the same on this branch and on dev/7.5.

[jacobtylerwalls]

Whoops, you called out iconclass, not graphid. Taking another look 👀

[jacobtylerwalls]

I still can't reproduce, but it looks like it could be a symptom of the graph publication lacking the iconclass. I know your graph object has an iconclass, but could you verify whether its related graph publication record has an iconclass? Or just a quick retest after a republishing.

[aj-he]

My mistake @jacobtylerwalls. I had been playing with graphs in the database and had forgotten to repubilsh them! Sorry for wasting your time.

[aj-he]

LGTM