Confirm the deletion details, #10185, #10186 #10194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 25, 2023
chiatt
requested changes
Nov 4, 2023
| except ValidationError: | ||
| return { | ||
| "success": False, | ||
| "data": {"title": _("Invalid Search Url"), "message": "Please, enter a valid search url "} |
There was a problem hiding this comment.
Could you make the message localizable as well?
| except TypeError: | ||
| return { | ||
| "success": False, | ||
| "data": {"title": _("Invalid Search Url"), "message": "Please, enter a valid search url "} |
There was a problem hiding this comment.
Message also needs to be translatable here too.
| for resourceid in smaple_resource_ids: | ||
| resource = Resource.objects.get(pk=resourceid) | ||
| resource.tiles = list(TileModel.objects.filter(resourceinstance=resourceid).filter(nodegroup_id=nodegroup_id)) | ||
| lbg = LabelBasedGraph.from_resource( |
There was a problem hiding this comment.
Is it possible to use LabelBasedGraphV2 here? The LabelBasedGraph may be replaced with V2, so it's best to avoid using it.
arches/app/templates/javascript.htm
Outdated
| delete-resource-count='(resource) => {return {% trans "${resource} resources will be deleted" as deleteResourceCount %} `{{ deleteResourceCount|escapejs }}` }' | ||
| delete-tiles='{% trans "Delete Tiles" as deleteTiles %} "{{ deleteTiles|escapejs }}"' | ||
| delete-resources='{% trans "Delete Resources" as deleteResources %} "{{ deleteResources|escapejs }}"' | ||
| to-be-deleted-tiles='{% trans "To Be Deleted Tiles" as toBeDeletedTiles %} "{{ toBeDeletedTiles|escapejs }}"' |
There was a problem hiding this comment.
The variable names are okay, but could the text be changed to "Tiles to Be Deleted"?
chiatt
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Issues Solved
#10185
#10186
Checklist
Ticket Background
Further comments