Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont check if data is sorted for custom reports #73

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tap_service_titan/streams/reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,21 @@ def __init__(self, *args, **kwargs) -> None: # noqa: ANN002 ANN003
)
self._curr_backfill_date_param: date | None = None

# This data is sorted but we use a lookback window to get overlapping historical
# data. This causes the sort check to fail because the bookmark gets updated to
# and older value than previously saved.
@property
def check_sorted(self) -> bool:
"""Check if stream is sorted.

This setting enables additional checks which may trigger
`InvalidStreamSortException` if records are found which are unsorted.

Returns:
`True` if sorting is checked. Defaults to `True`.
"""
return False

@property
def curr_backfill_date_param(self) -> date | None:
"""Get current backfill date parameter."""
Expand Down
Loading