Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for units to be sourced from outside. #2396

Closed
wants to merge 2 commits into from
Closed

Allow for units to be sourced from outside. #2396

wants to merge 2 commits into from
+12 −10

Conversation

thorstenhater
Copy link
Contributor

Closes #2392

@yurivict
Copy link

There is the failure with this patch:

CMake Error at CMakeLists.txt:313 (install):
  install TARGETS given target "units" which does not exist.

units shouldn't be installed by arbor's cmake scripts.

@thorstenhater
Copy link
Contributor Author

This should be subsumed by #2267 and would need a rewrite if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails with -DARB_USE_BUNDLED_UNITS=OFF because the install(units) statement is unconditional
2 participants
@thorstenhater @yurivict