fixed typos etc #2339
Merged
fixed typos etc #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ over the local and distributed hardware resources (see :ref:`pydomdec`). Then, t | |||
| # Instantiate the simulation. | |||
| sim = arbor.simulation(recipe, decomp, context) | |||
|
|
|||
| # Run the simulation for 2000 ms with time stepping of 0.025 ms | |||
| # Run the simulation for 2000 ms with a time step of 0.025 ms | |||
There was a problem hiding this comment.
These should have units ;)
thorstenhater
requested changes
Jul 31, 2024
| # To only record spikes from the local MPI rank, use arbor.spike_recording.local | ||
| sim.record(arbor.spike_recording.all) | ||
|
|
||
| # Run the simulation for 2000 ms with time stepping of 0.025 ms | ||
| # Run the simulation for 2000 ms with a time step of 0.025 ms |
There was a problem hiding this comment.
Same here, units missing. Again, not your fault, but let's do it right
Co-authored-by: Thorsten Hater <[email protected]>
thorstenhater
requested changes
Jul 31, 2024
doc/python/simulation.rst
Outdated
|
|
||
| # Sample probeset id (0, 0) (first probeset id on cell 0) every 0.1 ms | ||
|
|
||
| handle = sim.sample((0, 0), arbor.regular_schedule(0.1)) | ||
| handle = sim.sample((0, 0), A.regular_schedule(0.1)) |
thorstenhater
requested changes
Aug 1, 2024
Co-authored-by: Thorsten Hater <[email protected]>
Co-authored-by: Thorsten Hater <[email protected]>
thorstenhater
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.